web icon indicating copy to clipboard operation
web copied to clipboard

Thor fees in confirm modal are inaccurate

Open 0xApotheosis opened this issue 3 years ago • 2 comments

Overview

When swapping with Thor there are two issues with the fees shown on the confirm component:

  1. The ShapeShift fee is not 0 - it should always be 0.
  2. The buy amount is incorrect as it doesn't subtract the fee amount

References and additional details

Screen Shot 2022-08-18 at 4 40 05 pm

Acceptance Criteria

  1. ShapeShift fee is 0
  2. Buy amount accurate as to the amount that will actually be received

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

0xApotheosis avatar Aug 18 '22 19:08 0xApotheosis

@shapeshift/product I'm not sure of the ordering here, is this something we want fixed in the current swapper, or shall we wait until V2?

0xApotheosis avatar Aug 19 '22 06:08 0xApotheosis

@0xApotheosis I assumed we were waiting for the v2 swapper modal for this but if product wants it done now its easy enough. Just not sure where the thorchain fee would be displayed so waiting makes more sense to me

elmutt avatar Aug 22 '22 17:08 elmutt