web
web copied to clipboard
Thor fees in confirm modal are inaccurate
Overview
When swapping with Thor there are two issues with the fees shown on the confirm component:
- The ShapeShift fee is not 0 - it should always be 0.
- The buy amount is incorrect as it doesn't subtract the fee amount
References and additional details
Acceptance Criteria
- ShapeShift fee is 0
- Buy amount accurate as to the amount that will actually be received
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
@shapeshift/product I'm not sure of the ordering here, is this something we want fixed in the current swapper, or shall we wait until V2?
@0xApotheosis I assumed we were waiting for the v2 swapper modal for this but if product wants it done now its easy enough. Just not sure where the thorchain fee would be displayed so waiting makes more sense to me