shapeshift
Fee display handling in trade modal + displaying slippage amounts in fiat
Overview
Gm - Was going to combine this ticket with #2266 but it got too long so separated them.
This one is all about fee display handling in the trade modal and displaying slippage amounts. This came to the forefront due to how Cowswap calculates how much the user will receive, based on #2245 and as shown below where we give the impression the user is not losing any value due to slippage.
And with Cowswap, the user is shown that they will receive the same amount of $ in their desired asset, but Cowswap removes fees from the 'sell' asset. In screenshot below, user is shown they'll receive $10 DAI. However, after processing the transaction, they receive ~5 DAI because of fees + slippage.
The desired handling of this is outlined and shown below. Here is the Figma link for additional reference. Ty @reallybeard
User can enter amount to trade or receive, as normal. Slippage amounts in USD are shown below ($1,000 USDC showing as ~$993.27). Implementation of this closes #2245. User will see the amount they are due to receive, including fees.
Note - These numbers are taken directly from a real Cowswap trade.
Fee hover modal seen below.
Review screen below.
Pending confirmation screen below.
Final confirmation screen below.
References and additional details
Placeholder for technical implementation details.
Acceptance Criteria
- USD values shown with slippage reflected in trade modal on all steps
- Fee handling in trade modal is in accordance with Figma mockups to show user amounts, in fiat, lost to slippage and fees
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
@reallybeard has any code been written to create the interface in those new designs, or shall I start from scratch?
After checking with product this ticket is now to have the same information available to the user in the buy asset currency, rather than the fiat currency.