shapeshift
Text Not Translating
Overview
Market Data text on the assets and accounts page of an individual asset do not translate.
References and additional details
- log in to app.shapeshift
- choose you desired wallet
- do to the account or asset page for an individual asset
- on the bottom right of the screen look for "Market Data"
- Go to settings and change the language
- Notice the Market Data text does not translate
Additional translation errors below
Acceptance Criteria
Market Data text should translate
Need By Date
No response
Screenshots/Mockups
View a Demo not translating in Indonesian and Chinese:
Main title and view a demo not translating in Russian:
In Russian:
In Indonesian:
Spanish - Cosmos Defi:
Estimated effort
No response
As discussed on Discord with NeOMakinG, from the above examples the only case which isn't translatable currently is "Market Data". The problem is located here, the string should be passed through the translation function to be made available (@gomesalexandre : maybe you could look into it please?): https://github.com/shapeshift/web/blob/222fb5c40ec01e7687254ffdf31e40476efbf8a6/src/components/AssetHeader/AssetMarketData.tsx#L57
The other strings are apparently translatable, but are missing translations. Some have been translated since they were first posted here too. The full coverage provided by the Globalization WS is currently limited to Spanish/Portuguese/French and depending on the release cycles the translations might lag a few days behind new releases. Translations for other languages are planned to be done through bounties.
@NeOMakinG WRT the non-translated string, we will need to create a new 'assets.assetDetails.assetHeader.marketData' translation
Provided the PR for the translation, please don't close the issue as it doesn't fix everything
As far as I can see the other texts that are not translated in these screenshots are not an Engineering problem, the strings exist and they will eventually be translated by the Globalization Workstream (some are already translated on the Translation platform we use and waiting to be turned into a PR) at least in the 3 languages we can currently cover within the workstream's budget. As mentioned above the other languages that have partial translations are planned to be translated through bounties potentially. I don't think the issue needs to be kept open for these things to happen.
checked on this and most of the translation bugs have been fixed. Can see a few that are still be recreated. e.g. view a demo on chinese, indonesian, and russian. @firebomb1 @NeOMakinG not sure who is working on this issue 🙏
@Lychbot As stated before this issue can be closed from the point of view of the Globalization WS.
The related strings are now all translatable and are translated in Spanish/Portuguese/German/French (Note: Since the last time we have already added German to this list through bounties... so not all hope is lost for the other languages mentioned in the original issue). The other languages will be completed if/when the DAO can afford it.
If it's an issue to keep partially translated languages, we can see with Engineering to only enable the fully supported languages?
Also just for info three other issues have actual untranslatable strings currently and require Engineering's work, they are in the Backlog: https://github.com/shapeshift/web/issues/2175#issuecomment-1213536232 https://github.com/shapeshift/web/issues/2479#issuecomment-1223343076 https://github.com/shapeshift/web/issues/3083
Closing as the strings mentioned in this specific issue are all translatable, just not all translated.
The "incomplete" (not currently supported by Globalization) languages will be disabled soon through: https://github.com/shapeshift/web/issues/3182