web icon indicating copy to clipboard operation
web copied to clipboard

Keepkey with Passphrase on an older firmware version cannot connect on app.shapeshift.com

Open MBMaria opened this issue 3 years ago • 13 comments

Overview

After entering the pin for a KK with a passphrase on an older firmware version, it asks for the passphrase. At that point the front end hangs and the keepkey does not get past the "Waiting for Passphrase..." screen. This is due to the KK not being updated. Updating fw + bl fixes the issue

References and additional details

  1. Connect KK with Passphrase on app.shapeshift.
  2. Enter PIN.
  3. Enter passphrase.
  4. See hanging front end.
  5. See message on KK.

**only happens if KK is not updated

Acceptance Criteria

Should be able to connect to wallet with pin and passphrase. **needs product input on the expected message/flow

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • [X] If my bounty needs engineering or needs product I have added the respective labels on the right
  • [X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.

MBMaria avatar Apr 23 '22 02:04 MBMaria

@DiggyDiggy2 how does your team want the site to handle this issue?

MBMaria avatar Apr 23 '22 02:04 MBMaria

Closed accidently. Sorry about that.

MBMaria avatar Apr 23 '22 02:04 MBMaria

We are currently trying to replicate this.

DiggyDiggy2 avatar Apr 26 '22 16:04 DiggyDiggy2

@MBMaria have you upgraded the firmware on this device yet? if not, could you please physically get the device to @0xApotheosis to repro and diagnose?

0xdef1cafe avatar Apr 28 '22 16:04 0xdef1cafe

@DiggyDiggy2 I worked with @MBMaria and @Lychbot yesterday on this and was unable to recreate on my KeepKey that is on image

Neverwas-dev avatar Apr 28 '22 16:04 Neverwas-dev

During testing today I was able to recreate this with regularly and may have a possible root cause. I have since tested with @MBMaria and @Lychbot and we can all recreate with the following steps and this is for both older versions of firmware and bootloaders and the most recent. Recreation steps

  1. Log in to a different wallet and switch to KeepKey wallet
  2. Enter your pin code
  3. when prompted to enter phasePhrase either hit continue without entering or enter one
  4. the keepkey screen will be stuck on enter phase phrase and will not continue to load wallet
  5. To clear hard refresh the web page

Neverwas-dev avatar Apr 28 '22 22:04 Neverwas-dev

I can use @MBMaria's KeepKey to work through this.

0xApotheosis avatar Apr 29 '22 00:04 0xApotheosis

My keepkey is updated to the current bootloader and firmware. This ticket was created off a triage ticket put through by joshuAF so not sure if you will need my kk?

image

MBMaria avatar Apr 29 '22 00:04 MBMaria

This sounds like a bug to me, with older firmware that it's just hanging. Can we just fix this so it doesn't hang on that step? @0xdef1cafe - is this something for @pastaghost or Highlander?

DiggyDiggy2 avatar May 03 '22 20:05 DiggyDiggy2

assigning to KK workstream / @pastaghost

0xean avatar May 18 '22 20:05 0xean

@0xean Thanks for the ping for visibility - we'll get this in the queue right away.

pastaghost avatar May 18 '22 20:05 pastaghost

@markrypt0 to look at as per @pastaghost

0xdef1cafe avatar Jul 20 '22 19:07 0xdef1cafe

I just tested this and can confirm @Neverwas-dev's finding. The specific action causing the problem is Log in to a different wallet and switch to KeepKey wallet Otherwise it works without any problems that I can see.

The app is not initializing the keepkey when you switch wallets. This appears to be a client level problem, not really my purview. Maybe a bounty project?

markrypt0 avatar Jul 20 '22 21:07 markrypt0