web icon indicating copy to clipboard operation
web copied to clipboard

Add new underlying asset row to launch FOXy modal

Open BF2025DEV opened this issue 3 years ago • 14 comments

Overview

Gm!

When looking at FOXy asset details, there is no reference to it being a staked token, for easy access to the deposit and withdraw modal.

A solution for this was mocked up for Yearn, and can be seen below as the Underlying Asset box. This same functionality is desired for the FOXy asset page.

Screen_Shot_2022-04-07_at_5 12 13_PM

Underlying asset would be 'FOX' and upon click would bring the user to the FOX asset page (https://app.shapeshift.com/assets/eip155:1/erc20:0xc770eefad204b5180df6a14ee197d99d808ee52d) where they can manage their position.

References and additional details

Please ping @decentralized-j if further information is needed. Ty!

Acceptance Criteria

  1. FOXy asset page now shows an 'underlying asset' module
  2. Percentage return and number of FOX staked in FOX and USD shown
  3. Upon click, user is taken to FOX asset page

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • [X] If my bounty needs engineering or needs product I have added the respective labels on the right
  • [X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

3 hours.

Sponsor / Stakeholder

GitHub: 0xApotheosis Discord: 0xApotheosis#2503

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.

BF2025DEV avatar Apr 08 '22 16:04 BF2025DEV

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 660.0 FOX (243.18 USD @ $0.37/FOX) attached to it as part of the shapeshift fund.

gitcoinbot avatar Apr 15 '22 22:04 gitcoinbot

Hi @decentralized-j, maybe I misunderstood something, but I already see a box which references to staking on FOX asset page image

rast000 avatar Apr 15 '22 22:04 rast000

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 7 months from now. Please review their action plans below:

1) lolboysg has been approved to start work.

Hey, I would like to get this job done as I am already familiar with he codebase and it should be done within a day

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Apr 15 '22 23:04 gitcoinbot

Hi @decentralized-j, maybe I misunderstood something, but I already see a box which references to staking on FOX asset page

I believe this relates to the FOXy asset page, rather than FOX. FOXy's "underlying asset" is FOX, which we want to show on the FOXy page.

0xApotheosis avatar Apr 16 '22 01:04 0xApotheosis

Hi @decentralized-j, maybe I misunderstood something, but I already see a box which references to staking on FOX asset page

I believe this relates to the FOXy asset page, rather than FOX. FOXy's "underlying asset" is FOX, which we want to show on the FOXy page.

Exactly correct! Thank you for clarifying ser.

BF2025DEV avatar Apr 18 '22 13:04 BF2025DEV

@lolboysg could see that you have been approved to work. wanted to check, are you still working on this?

Lychbot avatar May 11 '22 05:05 Lychbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 660.0 FOX (115.87 USD @ $0.18/FOX) attached to this issue has been cancelled by the bounty submitter

gitcoinbot avatar May 17 '22 15:05 gitcoinbot

@lolboysg - can you please provide an update today or we will have to move to another contributor.

0xean avatar May 18 '22 20:05 0xean

I am awaiting for @decentralized-j answer to know if I should continue on this bounty as I don't know yet if I should implement a generic form of the staked asset modal or just hardcode one for foxy

0xtekgrinder avatar May 18 '22 20:05 0xtekgrinder

generic form please!

0xean avatar May 18 '22 22:05 0xean

removing this as a bounty for now basing on this convo in discord (https://discord.com/channels/554694662431178782/886041582422356018/968164015882764338)

Lychbot avatar Jun 01 '22 05:06 Lychbot

@shapeshift/operations this could be given to a trusted community contributor

0xdef1cafe avatar Jul 20 '22 19:07 0xdef1cafe

@0xdef1cafe on Discord you said: "Any work here will be rather futile at the moment given @Major Hayes working on single sided staking abstraction" (https://discord.com/channels/554694662431178782/886041582422356018/968164015882764338)

Has anything changed since that comment was made?

0xApotheosis avatar Jul 20 '22 20:07 0xApotheosis

@decentralized-j This is the current state of the "underlying assets" box :

underlying

This is pretty different from the expectation of this issue, is it expected to change this box for every underlying asset or should we do a specific display for FOXy / FOX ?

chxash avatar Jul 21 '22 08:07 chxash

@0xdef1cafe on Discord you said: "Any work here will be rather futile at the moment given @major Hayes working on single sided staking abstraction" (https://discord.com/channels/554694662431178782/886041582422356018/968164015882764338)

Has anything changed since that comment was made?

👋🏻

major avatar Nov 01 '22 21:11 major