react_on_rails icon indicating copy to clipboard operation
react_on_rails copied to clipboard

Require React 18

Open alexeyr-ci opened this issue 1 year ago • 1 comments

Summary

Remove this paragraph and provide a general description of the code changes in your pull request... were there any bugs you had fixed? If so, mention them. If these bugs have open GitHub issues, be sure to tag them here as well, to keep the conversation linked together.

Pull Request checklist

Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by ~.

  • [x] Add/update test to cover these changes
  • [x] Update documentation
  • [x] Update CHANGELOG file
    Add the CHANGELOG entry at the top of the file.

Other Information

Remove this paragraph and mention any other important and relevant information such as benchmarks.


This change is Reviewable

alexeyr-ci avatar Mar 09 '25 07:03 alexeyr-ci

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch alexeyr/require-react-18

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Mar 09 '25 07:03 coderabbitai[bot]

@alexeyr-ci2 What's the point of this PR?

justin808 avatar Aug 30 '25 02:08 justin808

@justin808 Added summary.

alexeyr-ci2 avatar Sep 15 '25 12:09 alexeyr-ci2

How big is this;

  • Optimize bundle size

Is this really worth changing now?

justin808 avatar Sep 17 '25 03:09 justin808

@justin808 It's mostly about making our code simpler, and simplifying maintenance for the future. Obviously not right now while HiChee isn't on React 18 yet. It will be more convenient to measure bundle size change once Popmenu is on ROR 15.

alexeyr-ci2 avatar Sep 17 '25 04:09 alexeyr-ci2

Closing stale draft PR (opened March 2025, 8 months old).

This work has been superseded by React 19 support which was recently merged:

  • #1942 - React 19 webpack configuration
  • #1943 - React 19 Pro package updates
  • #1944 - React 19 OSS package updates

React on Rails now supports React 19, making this React 18 requirement PR obsolete.

If there are specific changes from this PR that are still relevant, please open a new PR based on current master.

justin808 avatar Nov 09 '25 07:11 justin808