react-native-video-processing icon indicating copy to clipboard operation
react-native-video-processing copied to clipboard

Trimmer background color issue

Open chai86 opened this issue 6 years ago • 4 comments

How does one get rid of the charcoal dark grey trimmer background? Or at the very least change its color to match the backgroundColor of the screen?

Note: the green trimmer start and end markers are already at their extremities, these are the beginning and end of the video. So the dark color either side of the markers is the issue.

Screen Shot 2019-08-09 at 23 49 30

chai86 avatar Aug 09 '19 22:08 chai86

As a workaround, what I did was keep the trimmer at full width at all times, no matter the size of the video, by giving the <Trimmer/> component width={screenWidth}. It also looks prettier.

BaderSerhan avatar Sep 25 '19 09:09 BaderSerhan

@BaderSerhan I have tried this, but it doesn't look as good in my opinion. @shahen94 do you know how the color either side of the trimmer can be changed?

chai86 avatar Sep 25 '19 09:09 chai86

There's no implementation currently, but you can pass props down to the Trimmer and receive it in the Swift code

https://github.com/shahen94/react-native-video-processing/blob/master/ios/RNVideoProcessing/RNTrimmerView/RNTrimmerView.swift#L208

shahen94 avatar Sep 26 '19 10:09 shahen94

@shahen94 What would the props be to isolate the area outside the extremities of the markers?

As soon as you have the trimmer at a width that's less than the screen width, you always have these strange colors to the left and right of the markers.

chai86 avatar Sep 26 '19 20:09 chai86