Simon Garner

Results 62 comments of Simon Garner

This seems like something that nobody should be doing intentionally. But it could happen by mistake, so perhaps we should enforce (internally) that the primary key is always fetched regardless...

Can you share the contents of the generated migration(s) in your example?

> Of course, here is the generated migration Is that the first run? What does the second, duplicate migration look like?

This bug would have been introduced in: - #11269 @mnbaccari would you be able to take a look? The issue appears to be with this code, somehow we get here...

The quality of async stacktraces in Node depends on the Node version as well as how code is transpiled. So this might be a problem with the driver rather than...

Yes, without the option it would mean this change could be breaking for some users. I think that may still be preferable to adding an option that produces two different...

> Side note: it has always bugged me that `name` in `JoinColumnOptions` must be a column name, but `referencedColumnName` is a property name. Yes! There are several places where the...

@nlenepveu Could you please update the implementation to remove the `preserveSharedColumn` option and respect explicitly set column names instead? We will treat this as a bug fix rather than a...