formkit-primevue icon indicating copy to clipboard operation
formkit-primevue copied to clipboard

Declare prop types as described by FormKit docs

Open fermuch opened this issue 2 years ago • 3 comments

Hello! Great project and I love how organized it is. Adding & using it was a breeze!

Would it be possible to add the types of each component to FormKit as it is described in the docs?

fermuch avatar Apr 08 '24 17:04 fermuch

It seems this project cannot be used with FormKit/TypeScript until this is done, as the project will not build (unless strictly using schema)!

akkim2 avatar May 23 '24 22:05 akkim2

Hi, adding types is possible but not on the top of my list. If i have some spare time i will look into it.

Meanwhile if someone is willing to help i am glad to integrate a pull request for that topic.

Stay tuned,

Tom

sfxcode avatar May 28 '24 20:05 sfxcode

I started using this library and it is really interesting and useful. When I tried to build, however I ended up with the problem reported in this issue. I think typescript is almost a must now, I hope for a resolution.

Xeyos88 avatar Sep 29 '24 11:09 Xeyos88

I suggest to install the vue-tsc dependency and try to fix the main errors (not dev or test) given by the command
vue-tsc --build --force This at least makes it possible to build applications that use this library as a dependency and require type checking

Xeyos88 avatar Oct 22 '24 13:10 Xeyos88

type errors in src are fixed in latest build

https://github.com/sfxcode/formkit-primevue/releases/tag/v2.5.10

@Xeyos88 can you please test if it fixes your problem ?

Greetings and happy [typed] coding,

Tom

sfxcode avatar Oct 23 '24 15:10 sfxcode

Yes it works, now the build with typechek goes. I had to apply a few tricks to readjust my code but it works

Xeyos88 avatar Oct 23 '24 20:10 Xeyos88