dataprep icon indicating copy to clipboard operation
dataprep copied to clipboard

Data_connector: redesign query API.

Open peiwangdb opened this issue 5 years ago • 3 comments

Is your feature request related to a problem? Please describe. Current dc API requires the user to initialize a class and call the member function to issue a query.

Describe the solution you'd like We aim to redesign the APIs and allow the users to issue queries simply by functions just like EDA.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

peiwangdb avatar Jul 20 '20 23:07 peiwangdb

I think we keep the current implementation for better modulization, and implement a simplified API additionally.

dovahcrow avatar Jul 27 '20 00:07 dovahcrow

@jnwang @dovahcrow just want to confirm: are we okay with the current function API design that

  1. first connect with the websites
  2. and then query the specific API. Or we are open tp other possibilities like combining .connect and .query as well?

peiwangdb avatar Sep 25 '20 17:09 peiwangdb

@jnwang @dovahcrow just want to confirm: are we okay with the current function API design that

  1. first connect with the websites
  2. and then query the specific API. Or we are open tp other possibilities like combining .connect and .query as well?

I'm ok with separated functions since this looks more OO friendly and also they can be chained if a one-liner wants it.

@jnwang might have a different opinion.

dovahcrow avatar Oct 05 '20 01:10 dovahcrow