Seth Michael Larson

Results 529 comments of Seth Michael Larson

@joemarshall Thank you for opening this PR, this is really exciting stuff! :partying_face: I'll give this a full review later. I think my high-level comment for now is to add...

Thanks for the review @illia-v! @joemarshall are you still interested in landing this PR?

@bmckenna805 That's great news, maybe you can share here what you did for future folks?

This might have a harder time landing immediately now that the RC is here, but I agree that it's something we should get correct for 3.13 so that we don't...

As far as backporting to 3.13, I'll tag in @Yhg1s. The gist is that this API solidified, but didn't get applied to both places where peer certificates can be fetched....

@webknjaz Thanks for the report, do you happen to have the wheel that failed to upload on hand?

@webknjaz I did a little poking around and found that the SHA256 of `ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl` (the wheel that failed) that Sigstore computed during the PyPI upload (`cf5939d3918831bdb5178afa5818eedcc154fd202f64d38de7ad281702f50a93`) is different than the...

Looking at https://test.pypi.org/project/ansible-pylibssh/1.3.0a0/#files, it does look like TestPyPI had the same files uploaded as the ones in GHA artifacts.

Full list of hashes, note that the `(1)` filenames are from TestPyPI: ``` 7b24c62688d5bb3d35bec06acb6c5bd496936b947d8b8be5f1ec9030c4a975ab ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_aarch64.manylinux_2_28_aarch64(1).whl 7b24c62688d5bb3d35bec06acb6c5bd496936b947d8b8be5f1ec9030c4a975ab ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl 9bc8f02f58cab4a34ac870eb578d02e3c5e53a88120886c25b30198418578f13 ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_ppc64le.manylinux_2_28_ppc64le(1).whl 9bc8f02f58cab4a34ac870eb578d02e3c5e53a88120886c25b30198418578f13 ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_ppc64le.manylinux_2_28_ppc64le.whl cef00c730cbe8863a69a63314a4c958431502d4e617ac6a65fa6c10b45fe5d37 ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_s390x.manylinux_2_28_s390x(1).whl cef00c730cbe8863a69a63314a4c958431502d4e617ac6a65fa6c10b45fe5d37 ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_s390x.manylinux_2_28_s390x.whl d6ef10b8606c646f7a8c8d9cb3839660c82186f3c1f5eaa155c3fa43b8ab4fa2 ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64(1).whl d6ef10b8606c646f7a8c8d9cb3839660c82186f3c1f5eaa155c3fa43b8ab4fa2 ansible_pylibssh-1.3.0a0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl 533286335db65b8298b108fd2c6ad294c8d57df70459509dbd6478f06c18c8f8...

@webknjaz Yeah they're side-by-side, basically hashes from GHA artifacts and TestPyPI match.