Seth Michael Larson

icon indicating a website link https://sethmlarson.dev icon indicating an email [email protected]

icon company @psf icon location Minneapolis, MN icon location PSF Security Developer-in-Residence 🐍 PSF Fellow ✨ Minnesoootan, he/him

Results 529 comments of Seth Michael Larson

Update `next_event` annotation to reflect possible return types

I don't like the idea of exposing `Sentinel`, does `Union[..., Type[NEED_DATA], Type[PAUSED]]` not work for this case?

Update `next_event` annotation to reflect possible return types

This change seems good, it's unfortunate we got some formatting changes from black. Could you separate the formatting changes and change to the types into two separate commits so I...

Use allowlist_externals when next version of tox is released

Thank you! If you could provide a PR it'd be a quick review :)

Using Scorecard GitHub Action reduces the Token-Permissions score

@varunsh-coder Great question! I copied this output from this page: https://deps.dev/pypi/urllib3 to save me a second in running scorecard to get the output.

Feature: New check for SLSA provenance generation

Chiming in to say I'd like to start using SLSA with urllib3 but losing out on the `Signed-Releases` check we're currently getting from Sigstore would be unfortunate by changing to...

Feature: New check for SLSA provenance generation

I think that makes sense, especially as a means to convince people to start using SLSA.

Version 7.17.3 -> conda-forge

Hmm, is there a way we can manually trigger an upload? This one didn't get automatically opened.

Version 7.17.3 -> conda-forge

I've moved this issue to https://github.com/conda-forge/elasticsearch-feedstock/issues/73 as there's nothing to change on this repository. Hopefully the Conda team has a ready-made solution to our problem. :crossed_fingers:

parallel_bulk does not seem to respect chunk_size + parallel_bulk memory leak?

It does look like all the documents are loaded into memory to be distributed to workers. Would be better to use memory channels to distribute tasks.

Connection error with parallel testing

Our test suite isn't parallelizable in all cases due to setup and teardown of the Elasticsearch server. However when I try running with what I assume is `pytest-xdist` I don't...