Seth Michael Larson
Seth Michael Larson
Lots of great info @florimondmanca!! 🎉 I'm going to chime in here again at the idea of using AnyIO and adding our stream interface to that?
I'm in favor of adding websockets definitely, would be a good feature to work towards in a v2? Still so much to do to get a v1 released. Thanks for...
@aaugustin That's awesome news! :) Thanks for updating this thread. It'd be interesting to see how an upgrade from `h11` into the `websockets` state-machine might look. Something to definitely write...
Would be nice to answer the question "Why HTTPX versus A, B, or C?" better in the README. Even if it's just a small section.
Could this be solved by checking that `self._transport._loop` is not None within `StreamReader._maybe_resume_transport`? When I add that it doesn't complain about `_add_reader` not being an attribute of `NoneType`.
That's true, I'll look for a better fix with subprocess.
So I turned `SubprocessStreamProtocol.process_exited` into a no-op but that will leave the `Transport` unclosed but fixes the problem and all data is received. Perhaps there's a way to do this...
Submitted a PR #485 to fix this issue. Will work more on it tonight.
@fr0stbite I can take a look at this tonight if the problem persists.
@fr0stbite I'll be testing on Windows 10 Python 3.5.2 64 bit so I'll be able to reproduce easily. Hopefully we can get to the bottom of this.