Seth Michael Larson

icon indicating a website link https://sethmlarson.dev icon indicating an email [email protected]

icon company @psf icon location Minneapolis, MN icon location PSF Security Developer-in-Residence 🐍 PSF Fellow ✨ Minnesoootan, he/him

Results 530 comments of Seth Michael Larson

Remove workaround for old Python versions

@pquentin Hmm, the test suite is timing out? Any ideas why?

Replacement for scan helper function that uses search_after

Agree that this would be nice to have! I'll raise this as a feature request that all clients can implement for their scan helpers.

Add max_retry_wait_lenght to Retry

Thanks for opening this PR, however I'm of the opinion that we shouldn't continuously add functionality to what was originally a mostly simply `Retry` class. I'd like to rethink what...

to_dict serialize error

Can you give a full code example? I can't reproduce this without that.

Client authentication on Windows?

I would love to integrate with OS-specific APIs for their trust stores, but we'd be blazing our own trail a little bit in terms of how we expose them. Would...

Bug: `boost` instead of `boosts` in search()

Thanks for reporting this, I believe this is an issue with how the client is generated, I'll get this fixed there and then close this issue afterwards.

Use chunked REST serialization for large REST responses

@original-brownbear @DaveCTurner I would avoid using trailers if possible, many HTTP libraries don't process them or make them available to users so wouldn't be actionable from clients team.

Series methods `isna()`, `isnull()`, `notna()`, `notnull()` are returning ES query, rather than results.

Yeah this is unfortunately how Eland is implemented currently, you need to pass these filters into `df[...]` to take effect. I wonder if there's a way to have these functions...

'Requested column [0] is not in the DataFrame.'

I wonder if this is something with how Spark accesses the DataFrame and there are interfaces / behaviors that are missing from Eland's DataFrame.

Support aggregations on scripted fields

@V1NAY8 For some scripts we probably can't aggregate (like you've found with text). We should add test cases for the scripted fields we currently support to make sure we maintain...