Seth Michael Larson
Seth Michael Larson
Unfortunately I'm doubtful we'll be able to change that method to remove the `status_code` in the signature. Adding `response` is more likely but it would break users that subclass the...
At a minimum I'll mark this as something for 2.0.0 because I agree that we should be passing the whole response into the `Retry` object to allow for better subclassing...
@EnricoMi I think so! We can discuss the intricacies with code in front of us :) Thanks!
@shadycuz I admire your bravery, this issue is one of the big ones for v2.0 and is a tough one to tackle as your first PR to this repository. I've...
PR is here: https://github.com/shadycuz/urllib3/pull/1
@shadycuz Sounds great!
@shadycuz Great, thanks! Pypy is "slow" due to us running coverage during test execution. Pypy has poor performance when using coverage.
@shadycuz Wanted to follow up and let you know that this PR is 100% complete and is only waiting on external changes to happen to Requests. Thanks again for your...
@shadycuz That'd be great, going to tag @nateprewitt as he'd be the reviewer in that case.
@shadycuz Sorry for not providing you an update on the last ping. The plan iirc between @nateprewitt and I is to move Requests to not use the low-level HTTPConnection APIs...