C5 icon indicating copy to clipboard operation
C5 copied to clipboard

MoveNextAfterUpdate Test Seems to be Testing the Wrong Method

Open lundmikkel opened this issue 9 years ago • 1 comments

The MoveNextAfterUpdate() test in ArrayListTest seems to contain a mistake causing it to test the wrong thing:

[Test]
public void MoveNextAfterUpdate()
{
    list.Add(5);
    list.Add(8);
    list.Add(5);

    SCG.IEnumerator<int> e = list.GetEnumerator();

    e.MoveNext();
    list.Add(99); // <-- Bug: this should be Update()
    Assert.Throws<CollectionModifiedException>(() => e.MoveNext());
}

The test checks if calling Add() makes the enumerator fail. It should probably be a call to Update() instead.

I'm not sure if this mistake has been duplicated elsewhere.

lundmikkel avatar Mar 22 '16 11:03 lundmikkel

You're probably right. Perhaps you could make a pull request fixing these (there are a couple) Thanks

ondfisk avatar Apr 13 '16 07:04 ondfisk