C5 icon indicating copy to clipboard operation
C5 copied to clipboard

Bug in Tests Means that Only Added Events are Tested

Open lundmikkel opened this issue 9 years ago • 1 comments

In ArrayListTest events are not properly tested. The method listen() only adds event handlers to the Added event, thereby ignoring all other events:

private void listen() {
    seen.Listen(list, EventTypeEnum.Added);
}

This is correctly done in the HashedArrayListTest class:

private void listen() {
    seen.Listen(list, EventTypeEnum.All);
}

Be aware that fixing the listen() method will cause the Listenable() test to fail. It can, however, easily be fixed by inlining the method:

[Test]
public void Listenable()
{
    Assert.AreEqual(EventTypeEnum.All, list.ListenableEvents);
    Assert.AreEqual(EventTypeEnum.None, list.ActiveEvents);
    seen.Listen(list, EventTypeEnum.Added); // <-- Bug fix
    Assert.AreEqual(EventTypeEnum.Added, list.ActiveEvents);
}

lundmikkel avatar Mar 22 '16 10:03 lundmikkel

Again. Pull requests are accepted :)

ondfisk avatar Apr 13 '16 07:04 ondfisk