rust-cssparser icon indicating copy to clipboard operation
rust-cssparser copied to clipboard

Add benchmark tests for color parsing

Open GPHemsley opened this issue 3 years ago • 5 comments

Spinning off from #314:

With the complexities involved with parsing colors, there are concerned about regressing the time it takes to parse them.

Per @emilio:

But it should be rather trivial to add a few benchmarks for color parsing in src/tests.rs like we have for data: uris etc?

We should look into that.

GPHemsley avatar Jan 22 '23 16:01 GPHemsley

Hi :) Do you think this issue could be a good candidate to start contribute? If so, may I take this one?

sculpt0r avatar Dec 28 '23 19:12 sculpt0r

Hey, sure thing, go ahead!

emilio avatar Jan 01 '24 13:01 emilio

It has been a long time... If I'm not mistaken, there is no benchmarking at all in GH workflow, despite bench feature marks in the test code.

I'm fully rely on the docs: https://doc.rust-lang.org/unstable-book/library-features/test.html

So, part of this issue solve will be adding some custom workflow?

sculpt0r avatar Apr 03 '24 21:04 sculpt0r

I don't think we necessarily need a custom workflow, just something that can be benchmarked easily locally.

emilio avatar Apr 06 '24 17:04 emilio

Of course the more we can automate after that the better, but that's not a strict requirement imo.

emilio avatar Apr 06 '24 17:04 emilio