mozangle icon indicating copy to clipboard operation
mozangle copied to clipboard

mozangle seems to be being built twice

Open jrmuizel opened this issue 6 years ago • 6 comments

The first time we compile each file individually. The second time we pass all the files to a single cl instance. I don't yet understand why.

jrmuizel avatar Aug 16 '19 15:08 jrmuizel

We build both a static library and a DLL in https://github.com/servo/mozangle/blob/e344a1b183e4f0f56486a900e5461eafc236635d/build.rs#L99-L121.

jdm avatar Aug 16 '19 15:08 jdm

Ah. Maybe we should only build one depending on the needs of the consumer? Also one of them doesn't build in parallel.

jrmuizel avatar Aug 16 '19 15:08 jrmuizel

Also, is it necessary to build twice to produce both outputs?

jrmuizel avatar Aug 16 '19 15:08 jrmuizel

I honestly don't know. And yes, I would be open to adding features to control generation of the DLL and static libraries.

jdm avatar Aug 16 '19 16:08 jdm

If you can figure out a way to get the DLL to build in parallel, that would be helpful. Building shared libraries has been declared outside the scope of the cc crate, unfortunately.

jdm avatar Aug 16 '19 16:08 jdm

It looks like this is causing the webrender CI to timeout which is preventing the github repo from being updated: https://github.com/servo/webrender/pull/3753#issuecomment-530606372. @jdm is it possible for you to make this double building behaviour opt in?

jrmuizel avatar Sep 12 '19 00:09 jrmuizel