highfive icon indicating copy to clipboard operation
highfive copied to clipboard

Add an I-issue-report label to issue reports

Open asajeffrey opened this issue 9 years ago • 8 comments

https://github.com/browserhtml/browserhtml/pull/1152 adds an identifying string This report was generated by the browser.html issue reporter. to issue reports it generates. Highfive could use this information, for example to add an I-issue-report label to the issue.

asajeffrey avatar Jul 01 '16 16:07 asajeffrey

Please make a comment here if you intend to work on this issue. Thank you!

highfive avatar Jul 01 '16 16:07 highfive

cc @jdm

highfive avatar Jul 01 '16 16:07 highfive

Over in IRC (http://logs.glob.uno/?c=mozilla%23servo&s=1+Jul+2016&e=1+Jul+2016#c470789) @aneeshusa says this should be E-Easy.

asajeffrey avatar Jul 01 '16 16:07 asajeffrey

This belongs in a new handler in handlers which looks at the body of the issue and adds the label if necessary.

jdm avatar Jul 01 '16 16:07 jdm

Should we also add the I-panic tag? As these issue reports are only generated when a panic occurs?

cbrewster avatar Jul 01 '16 16:07 cbrewster

This will be a bit more work than originally anticipated, because we don't have any handlers that deal with opening new issues. We'll want to make the created event map to either on_new_pr or on_new_issue based on whether the pull_request field exists in the payload['issue'] object (see eventhandler.py).

jdm avatar Jul 01 '16 16:07 jdm

Yes, adding the panic tag would also be useful.

jdm avatar Jul 01 '16 16:07 jdm

At some point we may be getting error reports that aren't panics, but we can cross that bridge when we come to it.

asajeffrey avatar Jul 01 '16 19:07 asajeffrey