NPE in oscm-portal when using the external parameter configurator

[opetrovski]

[Version] 16.1 Fix 5

[How to reproduce]

• create a marketable service with external parameter configurator
• subscribe to that service

[Expected result]

• the subscription is created and the service parameter values are stored in the bss and app databases

[Observed result]

• no error message
• the subscription is created
• the service parameter values are NOT set
• the system.log of the oscm domain contains a NPE

[Details] Java throws a NPE when the value for a switch statement is null. A solution is that the validator returns an empty string instead of null when the validation is successful. See SubscriptionWizardConversation.validateConfiguredParameters() Line 560

see attached system.log oscm-system-log.txt

[kwodzynski]

Tested on Windows Server 2016, jdk1.8u131, build BES_MASTER_UNIT-1904 2017/07/27 (official 17.3.0) in SAML mode. After I configured "Parameters and options" and subscribed the subscription I have not received any errors in logs. But when I changed configuration in this place : /oscm-portal/marketplace/account/subscriptionDetails.jsf I received the same NPE

[ghost]

@kwodzynski please recheck, I cannot reproduce this

[kwodzynski]

Retested on openSUSE Leap 42.3 64-bit, openjdk 1.8.0_144, build 17.4.0 in SAML mode. When I changed configuration (after subscribed) in Account - Subscriptions - The subscription - Configuration - Parameters and options - I still receive NullPointerExceptions.