"VMWare controller:" Restore Operations shows 'Completed' even if operation failed

[AndreasTWolf]

[Version] V16.0 Fix 6 [Date] 2016/06/26

[Test category] Creative

[Description] Operation Restore executed but no Snapshot was executed before APP Service instance operation shows completed:

The Account View Operation page shows:

The logfile (APP-vmware-debug.log), however, states: [2016-07-06 16:14:01] [__ejb-thread-pool13] DEBUG VMController getInstanceStatus InstanceID: 1467805066456 | OrganizationID: da530744 | SubscriptionID: VMware_Original_With_ALL [2016-07-06 16:14:01] [__ejb-thread-pool13] DEBUG StateMachine loadStateMachine filename: restore_vm.xml [2016-07-06 16:14:01] [__ejb-thread-pool13] INFO States invokeAction Invoking action 'restoreSnapshot' of state 'BEGIN' for instance '1467805066456' [2016-07-06 16:14:02] [__ejb-thread-pool13] DEBUG VMwareClient isConnected vSphere connection is alive. Check took 411ms. URL: https://estvcenterdev1.intern.est.fujitsu.com/sdk/vimService?wsdl, UserId: FEST\estbuild [2016-07-06 16:14:02] [__ejb-thread-pool13] DEBUG DataAccessService getVCenterIdentifier vcenter: estvcenterdev1 [2016-07-06 16:14:02] [__ejb-thread-pool13] DEBUG DataAccessService getVCenterIdentifier vcenter: estvcenterdev1 [2016-07-06 16:14:02] [__ejb-thread-pool13] INFO RestoreActions restoreSnapshot Found no snapshot to restore for instance 1467805066456, virtual system 'Freddy-000049' and snapshot id null [2016-07-06 16:14:02] [__ejb-thread-pool13] DEBUG StateMachine getNextState Transition from current state 'BEGIN' with event 'success' into state 'END' [2016-07-06 16:14:30] [__ejb-thread-pool14] DEBUG VMController getInstanceStatus InstanceID: 1467814349989 | OrganizationID: d5b8f512 | SubscriptionID: VMware_Original_With_ALL [2016-07-06 16:14:30] [__ejb-thread-pool14] DEBUG StateMachine loadStateMachine filename: create_vm.xml [2016-07-06 16:14:30] [__ejb-thread-pool14] INFO States invokeAction Invoking action 'inspectTaskResult' of state 'CREATING' for instance '1467814349989'

[Steps to reproduce] Install vmware adapter subscribe to instance Do NOT call Operation "Snapshot" from "My Subscription" Page once instance is ready call Operation "Restore" from "My Subscription" Page [Expected result] Instance is up and running after the attempted Restore, but a info in the Operation Section telling me that the Restore failed. [Observed result] Everything looks ok, no message anywhere except in the APP-vmware-debug.log [Details] See above;

[Messages and logs]

[StavrevaS]

Some VMWare contorller issues are already solved from contributors. Check if the problem still exist, after the last contribution will be finished.