spin icon indicating copy to clipboard operation
spin copied to clipboard

Shell is also a script language

Open szepeviktor opened this issue 3 years ago • 2 comments

Current Behavior

... although it has much less tools than other script languages

Expected Behavior

  • [x] indent with 4 spaces - I hope 2 is not enough for you
  • [ ] move curly brace to a separate line
  • [ ] add shebang and script headers
  • [ ] move things without side effect (function declaration are not executed!) to the top
  • [ ] nice, decorative comments could be removed, use descriptive function names instead
  • [ ] Introduce shellcheck in CI
############################################################################################################
# nice, decorative comment
############################################################################################################

szepeviktor avatar Jun 30 '22 23:06 szepeviktor

Thanks @szepeviktor! I always appreciate learning from you. I will take a look into all of your suggestions and improve this on a future release 👍

jaydrogers avatar Jul 01 '22 13:07 jaydrogers

I leave the remaining 5 items to you.

szepeviktor avatar Jul 07 '22 06:07 szepeviktor

Moved to feature ideas: https://github.com/serversideup/spin/discussions/46

jaydrogers avatar Jan 04 '24 03:01 jaydrogers