synapse icon indicating copy to clipboard operation
synapse copied to clipboard

Allow creating workflow(s) by uploading Serverless Workflow definition file(s)

Open cdavernas opened this issue 3 years ago • 5 comments

What would you like to be added:

To allow creating workflow(s) by uploading a Serverless Workflow definition file(s)

Why is this needed:

Allows users to upload a file instead of copy/pasting JSON

cdavernas avatar May 19 '22 14:05 cdavernas

It requires an endpoint on the API to upload json/yaml/zip(or other archive formats)

JBBianchi avatar May 19 '22 15:05 JBBianchi

@JBBianchi is that endpoint really required though? I believe you should be able to read that file on the front-end side using the IWorkflowReader from the ServerlessWorkflow SDK.

That way, we avoid contacting the back-end for nothing, and can do client-side validation first hand, before using the ISynapseManagementApi.CreateWorkflowAsync method.

WDYT?

cdavernas avatar May 19 '22 15:05 cdavernas

Reading one file and posting its content isn't really a big challenge but it's a bit useless. From my understanding, file upload could be used for "projects", with multiple files (workflow, subflows and other references/resources). Am I missing something?

JBBianchi avatar May 19 '22 15:05 JBBianchi

From my understanding, file upload could be use for "projects", with multiple files (workflow, subflows and other references/resources)

Yeah, that's a very valid point. I'm on it!

cdavernas avatar May 19 '22 16:05 cdavernas

@JBBianchi My part's done ;)

image

cdavernas avatar May 20 '22 13:05 cdavernas