typescript icon indicating copy to clipboard operation
typescript copied to clipboard

Publish to NPM failed

Open fredericbarthelet opened this issue 2 years ago • 14 comments

Github action handling publishing of @serverless/typescript package to NPM currently fails. Last published version is 3.30.1 - versioning of this package follows serverless main package versions.

Failed job : https://github.com/serverless/typescript/actions/runs/5819791268/job/16047655020

I believe this could be due to changes made on serverless NPM team and currently used Github action secret NPM_TOKEN might not be valid anymore. Could someone from serverless team help here ?

fredericbarthelet avatar Aug 20 '23 16:08 fredericbarthelet

@ac360 could you help on the aforementioned issue :) ?

fredericbarthelet avatar Aug 20 '23 16:08 fredericbarthelet

Any updates about this issue?

fcappi avatar Sep 13 '23 08:09 fcappi

Edit : My bad, I hadn't read your comment about the token, you can disregard my comment :sweat_smile:

~~Hello @fredericbarthelet,~~

~~Apparently, npm can throw 404 when publishing if you are not logged in.~~

~~Are you sure the token you use when publishing is still valid? See here. Maybe your token has expired?~~

Ps : Thank you for you (amazing) work on this package :slightly_smiling_face:

guillaume-le-fur avatar Sep 20 '23 14:09 guillaume-le-fur

Any updates on this?

Node 20 lambda runtime has just been released and ppl will want type AwsLambdaRuntime updated from serverless.

herebebogans avatar Nov 16 '23 05:11 herebebogans

Any updates on this build issue ? I need to use the invokeMode config attribute

IdrissMahjoubi avatar Nov 25 '23 14:11 IdrissMahjoubi

@ac360 could you help on this issue and update the NPM_TOKEN value with a valid one in this repository secrets ? Thanks a lot for your help :)

fredericbarthelet avatar Nov 25 '23 14:11 fredericbarthelet

@austencollins could you help on this issue? If you can update the NPM_TOKEN value with a new valid one in this repository secrets, that'd be perfect! Thanks

fredericbarthelet avatar Jan 08 '25 19:01 fredericbarthelet

@fredericbarthelet Token has been updated, sorry about that.

Mmarzex avatar Jan 08 '25 19:01 Mmarzex

Great! Thanks @Mmarzex for your help! Could you run the workflow or give me back rights on this repo to run the workflow?

fredericbarthelet avatar Jan 08 '25 20:01 fredericbarthelet

@fredericbarthelet Looks like it isn't working, https://github.com/serverless/typescript/actions/runs/12678920352/job/35337545351

Mmarzex avatar Jan 08 '25 21:01 Mmarzex

@Mmarzex, I just updated a few actions on test and build definition workflows as well as stepping up node version. I just opened a pull request with the changes: https://github.com/serverless/typescript/pull/93

Installing dependencies seem to go like a charm: https://github.com/fredericbarthelet/serverlesstypescript/actions/runs/12679397766/job/35339008893. However, I'm blocked at npx sls schema step as I don't have a valid license key. Can I suggest you had a key from Serverless team as a secret in this repo under name SERVERLESS_LICENSE_KEY ?

fredericbarthelet avatar Jan 08 '25 21:01 fredericbarthelet

@Mmarzex , Can you please merge #93 and add either SERVERLESS_ACCESS_KEY or SERVERLESS_LICENSE_KEY ?

RishikeshDarandale avatar Jan 09 '25 06:01 RishikeshDarandale

@Mmarzex , can we please do this today?

RishikeshDarandale avatar Jan 10 '25 13:01 RishikeshDarandale

Going ahead with patch-package functionality for using serverless v4 feature, until #93 and this gets merged.

  • Copy the file(index.d.ts) from #92 to node_modules/@serverless/typescript/index.d.ts
  • Install patch-package with npm i patch-package
  • Run npx patch-package @serverless/typescripts
  • Add "postinstall": "patch-package" to your scripts in package.json

RishikeshDarandale avatar Jan 13 '25 06:01 RishikeshDarandale