serverless-google-cloudfunctions icon indicating copy to clipboard operation
serverless-google-cloudfunctions copied to clipboard

feat: build environment variables

Open shekhirin opened this issue 4 years ago • 5 comments

Google allows to update Build Environment Variables on deploy, so let's make use of such opportunity: https://cloud.google.com/functions/docs/env-var#updating_build_environment_variables.

buildEnvironmentVariables property is from REST API documentation https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions


Now we have a better solution for private Go dependencies than having a vendor. With build env vars, you can set GOPROXY and buildpack will fetch needed private dependencies through it. Yay.

shekhirin avatar Jul 07 '21 20:07 shekhirin

Hi @medikoo! Could you please review the PR when you have a time?

shekhirin avatar Jul 29 '21 16:07 shekhirin

Hello @shekhirin - sorry for not getting into your Pr sooner - could you please rebase it on top of current master and request a review from me? Thanks :bow:

pgrzesik avatar Sep 03 '21 13:09 pgrzesik

Hey @pgrzesik, just rebased! Seems like I don't have access to requesting a review 🤷‍♂️

shekhirin avatar Sep 03 '21 13:09 shekhirin

Just found this while looking for a way to set GOOGLE_FUNCTION_SOURCE which is critical for our deployment process and is the only thing blocking us from moving to GCP.

Any chance of getting this merged anytime soon? Thanks!

and3rson avatar Oct 10 '22 16:10 and3rson

@shekhirin Maybe you need to rebase this to resolve conflicts?

PrimeDominus avatar Jan 04 '23 10:01 PrimeDominus