serverless-next.js icon indicating copy to clipboard operation
serverless-next.js copied to clipboard

feat: Allow passing BucketDeployment lambda options

Open jlegreid opened this issue 3 years ago • 3 comments

jlegreid avatar Jun 27 '22 21:06 jlegreid

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit e6367b585fb98608cd2e9327e2c8d4058ba73b00)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1578,
            "Minified": 692
        },
        "Image Lambda": {
            "Standard": 1543,
            "Minified": 831
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1588,
            "Minified": 698
        },
        "Default Lambda V2": {
            "Standard": 1580,
            "Minified": 694
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1551,
            "Minified": 835
        },
        "Regeneration Lambda": {
            "Standard": 1233,
            "Minified": 566
        },
        "Regeneration Lambda V2": {
            "Standard": 1307,
            "Minified": 596
        }
    }
}

New Handler Sizes (kB) (commit 78024fb25f639f024f979e57abcf6b452da0d9dd)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1578,
            "Minified": 692
        },
        "Image Lambda": {
            "Standard": 1543,
            "Minified": 831
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1588,
            "Minified": 698
        },
        "Default Lambda V2": {
            "Standard": 1580,
            "Minified": 694
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1551,
            "Minified": 835
        },
        "Regeneration Lambda": {
            "Standard": 1233,
            "Minified": 566
        },
        "Regeneration Lambda V2": {
            "Standard": 1307,
            "Minified": 596
        }
    }
}

slsnextbot avatar Jul 20 '22 22:07 slsnextbot

Codecov Report

Merging #2457 (78024fb) into master (e6367b5) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2457      +/-   ##
==========================================
+ Coverage   83.85%   83.92%   +0.06%     
==========================================
  Files         102      102              
  Lines        3717     3726       +9     
  Branches     1191     1198       +7     
==========================================
+ Hits         3117     3127      +10     
+ Misses        588      587       -1     
  Partials       12       12              
Impacted Files Coverage Δ
...rless-components/nextjs-cdk-construct/src/index.ts 94.11% <100.00%> (+0.15%) :arrow_up:
...tjs-cdk-construct/src/utils/readAssetsDirectory.ts 100.00% <100.00%> (ø)
...s/nextjs-cdk-construct/src/utils/toLambdaOption.ts 100.00% <100.00%> (ø)
packages/libs/core/src/images/imageOptimizer.ts 84.51% <0.00%> (+0.41%) :arrow_up:

codecov[bot] avatar Jul 20 '22 22:07 codecov[bot]

@dphang Is there anything else I should do to make this PR ready for ship? I followed the contributing instructions, but I wasn't sure what the process is for getting it reviewed and merged. Thank you!

jlegreid avatar Aug 08 '22 16:08 jlegreid