serverless-appsync-simulator icon indicating copy to clipboard operation
serverless-appsync-simulator copied to clipboard

Invalid AWS Access Key ID

Open liam-ot opened this issue 2 years ago • 1 comments

Describe the bug AWS has updated their access key ID naming pattern which results in a breaking change when using VTL templates, serverless-offline, and this repo

I would be happy to open a PR but i dont know how to, i have the repo locally and the changes in a branch but i cannot push, instead git suggests i fork and push to that, is that the correct way to do it?

To Reproduce Use a VTL template

Expected behavior The VTL template should complete the request

Additional context I have a branch locally with the fix, it is two lines in the index.js file where the underscores are removed from the access key and secret.

liam-ot avatar Jul 03 '23 08:07 liam-ot

git suggests i fork and push to that, is that the correct way to do it?

Yes, I suspect this is the correct way to go about making a contribution.

These two docs articles may be relevant:

  • https://docs.github.com/en/get-started/quickstart/fork-a-repo#propose-changes-to-someone-elses-project
  • https://docs.github.com/en/get-started/quickstart/contributing-to-projects#forking-a-repository

domdomegg avatar Jul 04 '23 00:07 domdomegg