php-benchmark-script icon indicating copy to clipboard operation
php-benchmark-script copied to clipboard

Consider not deleting all tables in provided database

Open gmpf opened this issue 1 year ago • 1 comments

First of all, thank you for adding the feature that supports using an existing database via config/parameters rather than the user having to edit it into the code.

At the moment, however, the mysql benchmark script deletes all existing tables in the provided database. Is this really necessary? On existing systems, this behaviour limits the scope of use to databases created specifically for the test. Can't setup and teardown just delete only the table named test rather than everything? I don't see anything in the code that creates other tables, so I'm not sure what the advantage is of having it the way it is now.

gmpf avatar Nov 27 '24 15:11 gmpf

Seriously, what was even the thought process behind dropping all of the tables of a database? Nothing to call out the tables will be dropped so point it to another DB if you don't want your own data nuked.

jssellars avatar Jul 08 '25 15:07 jssellars