ctrl

ctrl copied to clipboard

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨 To enable Greenkeeper, you need to make sure that a [commit status](https://help.github.com/articles/about-statuses/) is reported on all...

greenkeeper[bot]

Object has no method 'redactor'

1

On the Admin/article when on html mode. Are you planning to use redactor in the future?

joaovpmamede

serby

Doubled up pre-create validators?

2

[Is this meant to be the case?](https://github.com/serby/ctrl/blob/master/bundles/article/lib/model.js#L96) Line 96-98 is duplicated exactly on line 100.

domdoescode

Default sections?

4

Should we add some default sections and content to ctrl when the first admin user creates an account? It seems a little misleading to have a '/blog' link in the...

domharrington

Do we really need _ or lodash?

13

Project wide search for `_.` returns 17 matches. - 16 of them are `_.extend()` - 1 of them is `_.pluck()` I think it would be better to use an extend...

bengourley

Rename serviceLocator to services

1

`serviceLocator` is a bit verbose. I think it'd be sensible to introduce the convention of calling it `services` (convention, rather than renaming the module, because it's up to the functions...

bengourley

Stylus is defined in web-stack.js

1

Is `web-stack.js` the right place do define stylusWatch and stylusCompile now that it's got nothing to do with HTTP?

bengourley

Generic Update Route gets object id from form field, not url param

3

An issue I found when I didn't realise the _id field was required on a generic view schema was that the update route didn't know what the object's id was....

bengourley

Should requests be logged in non dev environments?

2

The express logger might contain some useful debugging info. Currently we only log requests in development.

bengourley