serby
Doesn't work on a windows server with FF14 client
The slashes in the script tag become \ in windows and FF doesn't correct it It seems to work after changing filename in line 255 to filename.split(path.sep).join('/')
Thanks for letting me know. I think the problem comes from the normalize on line 166. I think that if removed it will fix the problem. Might need to remove any extra slashes too though.
It renders a single backslash now, instead of a double one, but FF still can't handle it.
Could you write a regression test to expose the problem and submit a pull request?
In the mean time I'll see if I can get a Windows setup to test it on.
On 5 September 2012 08:01, MauritsMeijer [email protected] wrote:
sorry, it works in production, doesn't in development mode.
— Reply to this email directly or view it on GitHubhttps://github.com/serby/compact/issues/23#issuecomment-8289401.
[email protected] Chief Technology Officer
Direct: +44 2030 516115__Mobile: +44 7881 550999 *
*
- http://www.clock.co.uk/ * * * The Old School HouseBridge Road, Hunton Bridge,Kings Langley, WD4 8RQ Switchboard: +44 1923 261166www.clock.co.uk * *
- http://twitter.com/clock https://github.com/clocklimited http://www.linkedin.com/company/clock-limited http://www.clock.co.uk/blog * * * www.clock.co.uk/email-disclaimer clock.® is a Registered Trademark of Clock Limited in the European Community and other territories
I'll see what I can do
Op 5-9-2012 10:23, Paul Serby schreef:
Could you write a regression test to expose the problem and submit a pull request?
In the mean time I'll see if I can get a Windows setup to test it on.
On 5 September 2012 08:01, MauritsMeijer [email protected] wrote:
sorry, it works in production, doesn't in development mode.
— Reply to this email directly or view it on GitHubhttps://github.com/serby/compact/issues/23#issuecomment-8289401.
[email protected] Chief Technology Officer
Direct: +44 2030 516115__Mobile: +44 7881 550999 *
*
- http://www.clock.co.uk/ * * * The Old School HouseBridge Road, Hunton Bridge,Kings Langley, WD4 8RQ Switchboard: +44 1923 261166www.clock.co.uk * *
- http://twitter.com/clock https://github.com/clocklimited http://www.linkedin.com/company/clock-limited http://www.clock.co.uk/blog * * * www.clock.co.uk/email-disclaimer clock.® is a Registered Trademark of Clock Limited in the European Community and other territories
— Reply to this email directly or view it on GitHub https://github.com/serby/compact/issues/23#issuecomment-8290960.
It's the normalize path on line 131 that is causing the problem. Removing it fixes that problem.
I can't get the testing stuff to work on Windows right now, so I'm gonna pass on writing a test.
Op 5-9-2012 10:23, Paul Serby schreef:
Could you write a regression test to expose the problem and submit a pull request?
In the mean time I'll see if I can get a Windows setup to test it on.
On 5 September 2012 08:01, MauritsMeijer [email protected] wrote:
sorry, it works in production, doesn't in development mode.
— Reply to this email directly or view it on GitHubhttps://github.com/serby/compact/issues/23#issuecomment-8289401.
[email protected] Chief Technology Officer
Direct: +44 2030 516115__Mobile: +44 7881 550999 *
*
- http://www.clock.co.uk/ * * * The Old School HouseBridge Road, Hunton Bridge,Kings Langley, WD4 8RQ Switchboard: +44 1923 261166www.clock.co.uk * *
- http://twitter.com/clock https://github.com/clocklimited http://www.linkedin.com/company/clock-limited http://www.clock.co.uk/blog * * * www.clock.co.uk/email-disclaimer clock.® is a Registered Trademark of Clock Limited in the European Community and other territories
— Reply to this email directly or view it on GitHub https://github.com/serby/compact/issues/23#issuecomment-8290960.