sequelize-auto icon indicating copy to clipboard operation
sequelize-auto copied to clipboard
verified publisher icon sequelize

fix: TypeScript model generation - use `declare` on all class fields and methods

Open duki994 opened this issue 3 years ago • 5 comments

Summary

  • Fixes TypeScript model generation
  • Related to issue https://github.com/sequelize/sequelize-auto/issues/600
  • declare all class fields … https://sequelize.org/docs/v6/core-concepts/model-basics/#caveat-with-public-class-fields

Description

All model classes were generated without declare keyword which made TypeScript to shadow Sequelize generated models.

Future plans

Create a PR with changes to code to use new InferAtributes and InferCreationAttributes

duki994 avatar Dec 01 '22 14:12 duki994

We would like to see this merged as it is currently causing issues in our TypeScript/ES2022 target codebase. What needs to be done to see this included?

jmfirth-arkane avatar Jul 10 '24 20:07 jmfirth-arkane

We would like to see this merged as it is currently causing issues in our TypeScript/ES2022 target codebase. What needs to be done to see this included?

Haven't worked in JS/TS ecosystem for a while.

I'll commit some of my OSS time to fix the issues as this modification had so many use cases across all TS projects I ever did.

duki994 avatar Jul 11 '24 10:07 duki994

I too would like this merged as the lack of declare on TypeScript fields is causing problems using the models generated by this.

csimpsonprepsportswear avatar Oct 22 '24 23:10 csimpsonprepsportswear

I need this too.

soknifedev avatar Jan 30 '25 01:01 soknifedev

please merge this... should be a very fast review and a big bug fix...

jlssmt avatar Jun 10 '25 15:06 jlssmt