tower-cli icon indicating copy to clipboard operation
tower-cli copied to clipboard

Launch with optimization turned off

Open JaimeSeqLabs opened this issue 1 year ago • 4 comments

Description

Closes #393

This PR adds support for disabling the optimized configuration when launching a pipeline by setting the --disable-optimization flag.

Guidelines for testing

  1. Create a new pipeline inside an organization workspace (optimization is available in non-personal workspaces only).
  2. Launch the pipeline once so the optimization becomes available. image
  3. Click on the light bulb and save the default optimization targets and values. image
  4. Verify that the pipeline is shown as optimized. image
  5. Launch the optimized pipeline and check that the configuration contains the optimized parameters. image
  6. Launch the optimized pipeline using ./tw with optimization turned off and check that the configuration does NOT contain the optimized parameters.
./tw launch HelloOptimization -w JaimeInc/Wsp --name=ThisShouldNotHaveOptimizations --disable-optimization

image

JaimeSeqLabs avatar Jun 18 '24 17:06 JaimeSeqLabs

Do I need to do anything special to get the optimization available?

I created a pipeline inside a workspace and ran it, but still can't see the lamp.

pgeadas avatar Jun 26 '24 14:06 pgeadas

I'm assuming you are running the pipeline in Seqera Platform (not in a local dev env)

Did the pipeline finish successfully?

I created a pipeline inside a workspace and ran it, but still can't see the lamp.

Is the lamp icon shown as unavailable or is it not shown at all?

JaimeSeqLabs avatar Jun 28 '24 13:06 JaimeSeqLabs

I'm assuming you are running the pipeline in Seqera Platform (not in a local dev env)

It can't be ran locally?

pgeadas avatar Jun 28 '24 14:06 pgeadas

It can't be ran locally?

It can, of course. But, given that tower-cli is a public repo, the test should be expected to run against prod so everyone can try it.

We can discuss offline the setup for the local instance.

JaimeSeqLabs avatar Jun 28 '24 14:06 JaimeSeqLabs

tested! works fine!

swampie avatar Jul 19 '24 16:07 swampie