tower-cli icon indicating copy to clipboard operation
tower-cli copied to clipboard

Send quote-enclosed pipeline name to API when retrieving pipeline.

Open robsyme opened this issue 2 years ago • 7 comments

Signed-off-by: Robert Syme [email protected]

robsyme avatar Nov 10 '23 21:11 robsyme

Closes https://github.com/seqeralabs/tower-cli/issues/360

robsyme avatar Nov 10 '23 21:11 robsyme

Not sure it's a good idea, why doing this?

pditommaso avatar Nov 13 '23 12:11 pditommaso

Not sure it's a good idea, why doing this?

What do you mean? my comment or the whole thing?

jordeu avatar Nov 13 '23 13:11 jordeu

The whole thing, IMO it should app invoking the CLI should take care of handling special chars

pditommaso avatar Nov 13 '23 13:11 pditommaso

The root of the problem is that here the CLI wants to do an exact match search by pipeline name because we expect the name to be unique. And the only way of doing this at API level is enclosing the name with quotes.

jordeu avatar Nov 13 '23 13:11 jordeu

I see; therefore, it's the field in the request. As such, should not be managed on BE side? how the FE handle this?

pditommaso avatar Nov 13 '23 13:11 pditommaso

I see; therefore, it's the field in the request. As such, should not be managed on BE side? how the FE handle this?

The FE do not has this need because it is always first doing a list of all the pipelines in a workspace and from that list knows the internal Id of the pipeline. So FE is never querying BE for a single pipeline by name.

jordeu avatar Nov 13 '23 13:11 jordeu

Closing this in favor of https://github.com/seqeralabs/tower-cli/pull/425

JaimeSeqLabs avatar Jun 19 '24 16:06 JaimeSeqLabs