sendgrid-go icon indicating copy to clipboard operation
sendgrid-go copied to clipboard

Fix!: The ability to get Content-Type value from attachments (Inbound Parse)

Open garydevenay opened this issue 5 years ago • 1 comments

Fixes #412

Previously we could not infer the content type of an attachment from it's contents (see #412) . I've updated the ParsedEmail Attachments property to be of (new) type ParsedAttachment. This new struct has it's "Content-Type" header populated on email parse and included tests.

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x] I have read the Contribution Guidelines and my PR follows them
  • [x] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added the necessary documentation about the functionality in the appropriate .md file
  • [ ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

garydevenay avatar Oct 27 '20 10:10 garydevenay

Thank you for the PR!

Could you please update your branch with the latest updates from main? It looks like I don't have permission to do so.

thinkingserious avatar Oct 28 '20 01:10 thinkingserious