java-http-client icon indicating copy to clipboard operation
java-http-client copied to clipboard
verified publisher icon sendgrid

Bump Sendgrid http client library to use latest apache http client 5

Open ahrooran-r opened this issue 1 year ago • 3 comments

This latest version of sendgrid does not support apache http client 5. I saw another issue where you are trying to use JDK specific http libraries. However, its been in stale since 2016 and last comment during 2022 also has no useful updates.

Could you please bump the library to use Http Client 5 at least? https://mvnrepository.com/artifact/org.apache.httpcomponents.client5/httpclient5

ahrooran-r avatar May 22 '24 05:05 ahrooran-r

Yes, for our project https://github.com/frankframework/frankframework we are using SendGrid as well, which uses this java-http-client which depends on the old org.apache.httpcomponents:httpclient:4.*.

jkosternl avatar Jun 20 '24 07:06 jkosternl

I raised a PR to bump the library to use httpclient5, since we use SendGrid in our project that we're upgrading to httpclient5.

ryantomlinson95 avatar Sep 06 '24 14:09 ryantomlinson95

Great job @ryantomlinson95 👍🏻
I hope the maintainers can proceed with your changes and merge it and release a new version.

jkosternl avatar Sep 07 '24 14:09 jkosternl