semaphore icon indicating copy to clipboard operation
semaphore copied to clipboard

Increase timeout for tests generating Semaphore proofs

Open vplasencia opened this issue 1 year ago • 1 comments

Description

There is an error when running the test workflow:

Proof › # generateProof › Should generate a Semaphore proof

    thrown: "Exceeded timeout of 20000 ms for a test.

https://github.com/semaphore-protocol/semaphore/actions/runs/8894821856/job/24423871569

vplasencia avatar Apr 30 '24 12:04 vplasencia

There are 2 different issues in that test(s):

  • Timeout for the proof generation: Increasing timeout can probably fix it. But I think the root cause is related to https://github.com/privacy-scaling-explorations/zk-kit/issues/280#issuecomment-2092459053
  • Structure of the test: Here We use a proof defined in the outer scope as parameter. It makes the tests depend on each others. As a result the test suite may produce unexpected results: a successful proof verification test requires the proof generation test having completed first, but jest executes everything in parallel...

sripwoud avatar May 03 '24 07:05 sripwoud

@vplasencia we shouldn't need this anymore. Can we close this issue?

cedoor avatar Jul 02 '24 13:07 cedoor

I will close it. The PR was already merged some time ago.

vplasencia avatar Jul 02 '24 13:07 vplasencia