github icon indicating copy to clipboard operation
github copied to clipboard

fix: include tag_name in updateRelease

Open kickapoo opened this issue 4 years ago • 3 comments

Problem

untagged release when a release includes assets upload.

Fix

When release with assets is needed, we update previously created draft release (in order to attach assets) by adding tag_name in github api call . tag_name option in not required based on git docs.

Details in https://github.com/semantic-release/github/issues/362

Must read comment: https://github.com/semantic-release/github/issues/362#issuecomment-830261465

NOTE

DRAFT PR since my skills aren't node based (python dev). Need time to understand/learn/explore the unit tests failures. Help is appreciated.

kickapoo avatar May 01 '21 18:05 kickapoo

FYI: I work in @kickapoo's sister team, and while I'm not a node developer specifically, I am a javascript developer, and I'm happy to help out as best I can.

adrianschmidt avatar May 03 '21 07:05 adrianschmidt

I've fixed the lint errors and the failing tests in two fixup-commits, intended to be squashed into the main commit before merge, but I will of course be happy to edit the commits, if you have any other preference.

adrianschmidt avatar May 03 '21 10:05 adrianschmidt

Seem can not add you as reviewer so cc , @gr2m

kickapoo avatar May 03 '21 10:05 kickapoo