github icon indicating copy to clipboard operation
github copied to clipboard

feat: make success comments filterable

Open balazsorban44 opened this issue 4 years ago • 6 comments

Fixes #359

balazsorban44 avatar Apr 23 '21 15:04 balazsorban44

I know this isn't particularly helpful, but my team has been running into this as well, and would love to see this merged in. If there's anything I can do to assist, please feel free to let me know!

jpsullivan avatar May 24 '21 06:05 jpsullivan

Of course! I can do, that, if you point me to the right place. 😊

balazsorban44 avatar May 25 '21 13:05 balazsorban44

I'm not an official maintainer, though if I were to assume I'd go ahead and drop the successFilter into the Options category of the README. https://github.com/semantic-release/github/blob/master/README.md#options, providing a brief description and maybe some example values.

oljp avatar May 25 '21 15:05 oljp

sorry for the delay with reviewing PRs. We are all pretty swamped right now, but how to find time to review the open PRs and onboard new maintainers soon

gr2m avatar May 25 '21 23:05 gr2m

Any reason this is not merged? Currently I have the problem that if semantic-release with github gets added to an old repo with thousands of merged pr's, you end up with thousands of comments done by semantic-release. I wonder why this was not yet mentioned anywhere. A filter would help in this case, we could add the released label manually to all merged pr's before introducing semantic-release. Alternative solution might also the ability to specify a custom github search query.

raffis avatar Nov 04 '22 09:11 raffis