Selwin Ong

Results 533 comments of Selwin Ong

`queue.enqueue_job()` just enqueues the job without doing any dependencies check, it's designed for that. Is there a reason why you don't use `queue.enqueue()` instead?

The intended design for `enqueue_job()` was to just push a job into a queue. I do understand the confusion though, in hindsight we should have made this into an internal...

@caffeinatedMike yeah, it definitely looks like a bug. If a job is scheduled with a dependency, it should always go to `DeferredJobRegistry` instead of `ScheduledJobRegistry`. You found so many bugs...

@caffeinatedMike obviously I was joking about the last bit. Keep up the good work 😄

Hey, this is a good idea, but I'd like this to be implemented via the newly added [Dependency class](https://github.com/rq/rq/blob/5b95725dc4410634a658bda9aa59188eaeaf87ea/rq/job.py#L41). This is how the API should look like: ```python queue.enqueue(foo, depends_on=Dependency(bar,...

A reminder to make this change when you're free :).

Agreed. However, the checks shouldn't be done everytime the keys are incremented as this will incur one extra Redis operation for every job that finishes. The check should only be...

I think this is a very interesting idea and something I'd like to have. Rather than configuring this on a per job basis though, I think I'd like to see...