selectize.js icon indicating copy to clipboard operation
selectize.js copied to clipboard

Sass compilation errors with Bootstrap 5.3.1

Open cpsievert opened this issue 2 years ago • 2 comments

Bootstrap 5.3.1 moves more colors from Sass to CSS variables, which causes a couple compilation errors. Specifically,

https://github.com/selectize/selectize.js/blob/e3f2e0b4aa251375bc21b5fcd8ca7d374a921f08/src/scss/selectize.bootstrap5.scss#L29-L33

Doesn't work anymore since $input-bg's value now contains a CSS variable...

Error: argument `$color2` of `mix($color1, $color2, $weight: 50)` must be a color
        on line 26:36 of inst/www/shared/selectize/scss/selectize.bootstrap5.scss, in function `mix`
        from line 26:36 of inst/www/shared/selectize/scss/selectize.bootstrap5.scss
        from line 21:9 of stdin
>> $select-color-dropdown-border-top: mix(

For similar reasons, this code:

https://github.com/selectize/selectize.js/blob/e3f2e0b4aa251375bc21b5fcd8ca7d374a921f08/src/plugins/dropdown_header/plugin.scss#L7

Results in

Error: argument `$color1` of `mix($color1, $color2, $weight: 50)` must be a color
        on line 7:17 of inst/www/shared/selectize/plugins/dropdown_header/plugin.scss, in function `mix`
        from line 7:17 of inst/www/shared/selectize/plugins/dropdown_header/plugin.scss
        from line 77:9 of inst/www/shared/selectize/scss/selectize.scss
        from line 53:9 of inst/www/shared/selectize/scss/selectize.bootstrap5.scss
        from line 21:9 of stdin
>>     background: mix($select-color-dropdown, $select-color-border, 85);

cpsievert avatar Aug 17 '23 21:08 cpsievert

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Dec 16 '23 02:12 github-actions[bot]

Commenting to keep open

cpsievert avatar Dec 18 '23 15:12 cpsievert

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Apr 19 '24 02:04 github-actions[bot]

This appears to still be a problem - trying to update boostrap to 5.3.3 doesn't work. @cpsievert appears to have a fix, but doesn't seem to have been merged/released?

ejn avatar Jul 26 '24 06:07 ejn