PcapPlusPlus icon indicating copy to clipboard operation
PcapPlusPlus copied to clipboard

Find alternative package for netifaces

Open zhengfeihe opened this issue 1 year ago • 1 comments

I found netifaces package is no longer under maintained since python3.9 , detailed info here: https://github.com/al45tair/netifaces/issues/78. Some other projects have moved to using other packages, eg psutil: https://github.com/ros2/ros2cli/pull/875

Maybe we can also move to using other under maintained, reliable packages as well.

zhengfeihe avatar May 05 '24 10:05 zhengfeihe

I'd like to work on this after I finish my current pr.

zhengfeihe avatar May 05 '24 10:05 zhengfeihe

@zhengfeihe are you still planning to work on this?

seladb avatar Jun 15 '24 03:06 seladb

By the way, there is this project: https://github.com/SamuelYvon/netifaces-2

But I'm not sure it'll work well on FreeBSD: https://github.com/SamuelYvon/netifaces-2/issues/36

seladb avatar Jun 15 '24 08:06 seladb

FreeBSD can be treated as a special case, I guess.

tigercosmos avatar Jun 15 '24 10:06 tigercosmos

FreeBSD can be treated as a special case, I guess.

Maybe... or we can try to fix this package to work with FreeBSD, or we can choose another library 🙂

seladb avatar Jun 15 '24 20:06 seladb

@zhengfeihe are you still planning to work on this?

Yes.. Just got delayed onmy current pr. I will start working on this soon.

zhengfeihe avatar Jun 16 '24 00:06 zhengfeihe

@zhengfeihe I think you might want to work on this, going to assign you.

tigercosmos avatar Jun 24 '24 02:06 tigercosmos

@zhengfeihe I think you might want to work on this, going to assign you.

Thanks! I already started.

zhengfeihe avatar Jun 30 '24 14:06 zhengfeihe

As we need to support Ubuntu24.04, this issue seems to become critical at the moment. Some error happens in the CI of the PR #1486: Log

tigercosmos avatar Jul 07 '24 08:07 tigercosmos

@zhengfeihe please confirm if you can submit the PR for this by today; otherwise, I am sorry that I have to unassign you and take over this issue.

tigercosmos avatar Jul 07 '24 08:07 tigercosmos

@zhengfeihe please confirm if you can submit the PR for this by today; otherwise, I am sorry that I have to unassign you and take over this issue.

I will submit the pr by the end of the day.

zhengfeihe avatar Jul 07 '24 08:07 zhengfeihe

addressed in https://github.com/seladb/PcapPlusPlus/pull/1489

tigercosmos avatar Aug 14 '24 07:08 tigercosmos