sei-chain icon indicating copy to clipboard operation
sei-chain copied to clipboard

Fix staking precompile events: ABI-derived event IDs + test coverage

Open Pray4Lovee opened this issue 5 months ago • 1 comments

This PR corrects staking precompile event emission to ensure ABI-derived event IDs are used consistently, matching downstream consumers’ expectations.

Updated staking.go to emit EmitDelegateEvent / EmitUndelegateEvent with canonical ABI event selectors.

Added targeted test coverage to staking_events_test.go verifying correct event ID derivation and log emission.

Resolved merge artifacts from upstream sync.

Verified all existing staking precompile tests still pass.

Impact: Ensures EVM-compatible event logs are emitted for staking actions, improving indexer compatibility and enabling external integrations (including x402 settlement tracking).

Testing:

Ran full test suite with go test ./precompiles/staking/... – all passing.

Manual verification via simulated EVM calls confirmed correct event log output

Pray4Lovee avatar Aug 11 '25 15:08 Pray4Lovee

We truly appreciate your contribution and the time you’ve invested in this PR. Before we can merge it, we’d love your help addressing the remaining feedback or sharing your perspective. If we don’t hear back within 2 day(s), this PR will close automatically — but don’t worry, you can reopen it anytime when you’re ready to continue.

github-actions[bot] avatar Nov 09 '25 12:11 github-actions[bot]

This PR is being closed due to inactivity, but we want to acknowledge and thank you for the effort you’ve put in. Please feel free to reopen it whenever you’re ready to pick it back up.

github-actions[bot] avatar Nov 15 '25 12:11 github-actions[bot]