sei-chain icon indicating copy to clipboard operation
sei-chain copied to clipboard

Integrate with tendermint EVM tx replacement logic

Open codchen opened this issue 1 year ago • 1 comments

Describe your changes and provide context

See description in https://github.com/sei-protocol/sei-tendermint/pull/206

This PR also includes changes to handle duplicate nonces in the pending nonce list in evmKeeper

Testing performed to validate your change

local sei test

Block time -> 10s

block 1
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 1000 --from=admin --nonce=0 --gas-fee-cap=1000000000000
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 2000 --from=admin --nonce=0 --gas-fee-cap=1100000000000

block 1
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 1000 --from=admin --nonce=0 --gas-fee-cap=1000000000000
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 2000 --from=admin --nonce=0 --gas-fee-cap=900000000000

block 1
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 1000 --from=admin --nonce=0 --gas-fee-cap=1000000000000
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 2000 --from=admin --nonce=2 --gas-fee-cap=1000000000000
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 3000 --from=admin --nonce=2 --gas-fee-cap=1100000000000
block 2
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 10000 --from=admin --nonce=1 --gas-fee-cap=1000000000000
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 100000 --from=admin --nonce=3 --gas-fee-cap=1000000000000

block 1
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 1000 --from=admin --nonce=0 --gas-fee-cap=1000000000000
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 2000 --from=admin --nonce=2 --gas-fee-cap=1000000000000
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 3000 --from=admin --nonce=2 --gas-fee-cap=900000000000
block 2
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 10000 --from=admin --nonce=1 --gas-fee-cap=1000000000000
seid tx evm send 0x9f76969569764cFc33D597D0eb00242cDB11EAE2 100000 --from=admin --nonce=3 --gas-fee-cap=1000000000000

codchen avatar Feb 28 '24 05:02 codchen

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 63.32%. Comparing base (f23a1fa) to head (4ab8c40).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              evm    #1394      +/-   ##
==========================================
+ Coverage   63.02%   63.32%   +0.30%     
==========================================
  Files         350      350              
  Lines       23760    23788      +28     
==========================================
+ Hits        14974    15064      +90     
+ Misses       7926     7861      -65     
- Partials      860      863       +3     
Files Coverage Δ
app/app.go 68.44% <100.00%> (+0.02%) :arrow_up:
x/evm/ante/sig.go 84.12% <100.00%> (ø)
x/evm/keeper/keeper.go 85.64% <89.36%> (+1.71%) :arrow_up:

... and 4 files with indirect coverage changes

codecov[bot] avatar Feb 28 '24 06:02 codecov[bot]