sehugg
When opening repo dir, platform is reset to vcs
If I type in a link like the following to my browser:
https://8bitworkshop.com/dev/?repo=micahcowan%2Fa2allchars&platform=apple2&file=allchars.c
The platform gets reset to "VCS". I must then manually select the "Apple ][+" platform, which behaves as expected; but if I go back up to the address bar, click it and hit return, the platform is reset again. This happens on current /dev/, but not /v3.9.0/, which keeps the platform specified in the URL (as expected).
(repo micahcowan/a2allchars is obtained to your browser storage by clicking this link - clicking it will work as expected, redirecting to the above-shown URL, but if you then click the address bar and type a return, it's reset)
That's probably due to commit 8b23e9872e07bfe66269177889680a7a26c5bae8 which attempts to fix another bug -- that the platform is reset to VCS if you open a repo link for the 1st time or in a private window. I probably should add a bunch of test cases similar to test/web/testembed.js and test/fix all the edge cases.
There should eventually be a way to switch platforms while inside a repo, too, so you can develop cross-platform projects.
Oh yeah that could be it - looks like setting platform_id from the qs went from unconditional to conditional, with the possible result that the platform setting in the qs might get ignored.