8bitworkshop icon indicating copy to clipboard operation
8bitworkshop copied to clipboard

Cannot build with current instructions

Open pbpalomino opened this issue 5 years ago • 8 comments

Running the instructions provided in Readme.md it does not work. How to fix this ?

Steps (clean install )

SMP Debian 4.19.146-1 (2020-09-17) node v10.21.0 npm 6.14.8

sudo apt-get install gcc g++ make htop git sudo apt-get install nodejs npm mocha sudo npm install -g npm@latest sudo npm install make -g sudo npm install npm-install-missing -g sudo apt-get update sudo apt-get upgrade

git clone https://github.com/sehugg/8bitworkshop.git chmod -R 777 8bitworkshop/ cd 8bitworkshop/ git submodule init git submodule update npm-install-missing

Package Current Wanted Latest Location chokidar MISSING 3.4.2 3.4.2 8bitworkshop electron-store MISSING 6.0.0 6.0.0 8bitworkshop jquery MISSING 3.5.1 3.5.1 8bitworkshop reflect-metadata MISSING 0.1.13 0.1.13 8bitworkshop update-electron-app MISSING 1.5.0 2.0.1 8bitworkshop [ [ 'chokidar', '3.4.2' ], [ 'electron-store', '6.0.0' ], [ 'jquery', '3.5.1' ], [ 'reflect-metadata', '0.1.13' ], [ 'update-electron-app', '1.5.0' ] ] Segmentation fault.] - extract:update-electron-app: http fetch GET 200 https://

pbpalomino avatar Sep 28 '20 15:09 pbpalomino

Do you have "make" installed?

sehugg avatar Sep 28 '20 15:09 sehugg

Do you have "make" installed?

Yes, all installed. [email protected]. Going to post the steps to reproduce it later.

pbpalomino avatar Sep 28 '20 15:09 pbpalomino

I mean the command-line GNU make, not the Node package. Try: apt-get install make

sehugg avatar Sep 28 '20 20:09 sehugg

I mean the command-line GNU make, not the Node package. Try: apt-get install make

Posted steps to reproduce build errors from clean install.

pbpalomino avatar Sep 29 '20 19:09 pbpalomino

I can confirm strange issues building with current instructions on Ubuntu 20.04, and Raspbian 64-bit. From a clean Ubuntu 20.04, tag 3.7.0 will not build and gives the following log:

patch -i meta/electron.diff -o electron.html
patching file electron.html (read from index.html)
Hunk #1 FAILED at 3.
Hunk #2 FAILED at 22.
Hunk #3 succeeded at 65 (offset -25 lines).
Hunk #4 succeeded at 90 (offset -25 lines).
Hunk #5 FAILED at 210.
Hunk #6 succeeded at 403 (offset -25 lines).
3 out of 6 hunks FAILED -- saving rejects to file electron.html.rej
make: *** [Makefile:6: all] Error 1
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build: `make`
npm ERR! Exit status 2

Rolling back to tag 3.6.0 does successfully compile on both the Ubuntu machine and the Raspberry Pi. Node version: v10.19.0 NPM version: 6.14.4

youkaicountry avatar Dec 08 '20 06:12 youkaicountry

Fixed, current HEAD now builds on Travis CI.

sehugg avatar Dec 08 '20 20:12 sehugg

And now I can confirm that the latest commit 1d952ad successfully builds on both systems. Thanks!

youkaicountry avatar Dec 09 '20 07:12 youkaicountry

Thanks a lot.

pbpalomino avatar Dec 21 '20 16:12 pbpalomino