analytics.js-core icon indicating copy to clipboard operation
analytics.js-core copied to clipboard

chore(deps): update uuid to v8 since v3.4 is deprecated

Open cajotafer opened this issue 3 years ago • 0 comments

Description

I am getting this warning using Yarn 2

uuid@npm:3.4.0 is deprecated: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

I realized this package is using [email protected] and I think is a good idea to upgrade it to v8, no breaking changes included. I have followed this doc https://github.com/uuidjs/uuid#upgrading-from-uuid3

Test plan

  • Testing completed successfully using - tried to run yarn test but I've got an error IDK exactly how to fix. image

Release plan

HISTORY.md has been updated.

Checklist

  • [x] Thorough explanation of the issue/solution, and a link to the related issue
  • [ ] CI tests are passing
  • [ ] Unit tests were written for any new code
  • [x] Code coverage is at least maintained, or increased.

Resolves https://github.com/segmentio/analytics.js-core/issues/273

cajotafer avatar May 27 '22 06:05 cajotafer