analytics-php icon indicating copy to clipboard operation
analytics-php copied to clipboard
verified publisher icon segmentio

fix: allow passing milliseconds in event timestamp

Open antonioturdo opened this issue 1 year ago • 3 comments

The presence of the cast to integer makes it impossible to specify a timestamp with milli / micro seconds.

#234

antonioturdo avatar Jul 06 '24 10:07 antonioturdo

@antonioturdo Thank you for this update

Can you modify your branch so we can pass our coding standards tests: Error: Header blocks must be separated by a single blank line Error: Missing declare(strict_types=1). Error: String "3.8.0" does not require double quotes; use single quotes instead

Not sure how that reverted on your branch Much appreciated

nd4p90x avatar Sep 04 '24 17:09 nd4p90x

Hi, it looks like the Version.php file is autogenerated, so I also changed the Makefile. I have no experience with make, so I hope I didn't break anything using single/double quotes.

antonioturdo avatar Sep 05 '24 14:09 antonioturdo

Hi, it looks like the Version.php file is autogenerated, so I also changed the Makefile. I have no experience with make, so I hope I didn't break anything using single/double quotes.

Thanks for that. If anything happens, we will fix it in post

nd4p90x avatar Sep 05 '24 18:09 nd4p90x