analytics-go

analytics-go copied to clipboard

Add context in Callback

2

Is it possible to add context in OnSuccess and OnFailure callbacks for proper span tracing?

jtejido

Typo in Product struct?

1

https://github.com/segmentio/analytics-go/blob/30e6f7a7ae3d5a98f960c3f6464d968e73cc47eb/properties.go#L114 Shouldn't it be "json:"**sku**,omitempty""?

TonyZZX

Go mod incompatibility

8

There is a small issue in the versioning of this repo causing go mod to think it incompatible with versioning. If you look [here in the godocs](https://pkg.go.dev/github.com/segmentio/[email protected]+incompatible?tab=versions) you can see...

AndrewBurian

v3.2.1 not loadable thru gopkg.in

4

Up until last night it appears v3.1.0 was mirrored to gopkg.in and that worked. But as of this morning it is picking up v3.2.1 and that doesn't load. There are...

rlk833

Line 14: ``` go get https://github.com/segmentio/analytics-go ``` Should be: ``` go get github.com/segmentio/analytics-go ```

peterstirrup

wait for requests to finish on flush

1

This helps guarantee that all requests are made when the quit signal is received. The previous `wg.Done()` did nothing since it was deferred.

kushmansingh

Any way to check if all messages sent before calling client.Close()?

13

Using `analytics-go.v3`. The `Client` interface has a comment that outlines the client setup: ```go // client := analytics.New(writeKey) // ... // client.Enqueue(analytics.Track{ ... }) // ... // client.Close() ``` I'm...

defrankland

Make sure that even when response status is

eitankatznelson

Response body not always fully read

1

The http.Do function documentation states that: ``` // If the returned error is nil, the Response will contain a non-nil // Body which the user is expected to close. If...

eitankatznelson

Library hasn't been released for a very long time and released version with vendoring seems to be failing to build with latest go (vendored dependencies to be specific)

wtrocki