action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

[liquid metrics] Adds items from Subscription object to tags

Open nick-Ag opened this issue 8 months ago • 1 comments

This PR adds new tags to the metrics tracked for Liquid Functions, including the projectId to narrow down metrics to users. This is a followup to https://github.com/segmentio/action-destinations/pull/3024

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

Successfully tested in staging - the tags come back as expected: Screenshot 2025-08-18 at 10 01 56 AM

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [x] [Segmenters] Tested in the staging environment
  • [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

nick-Ag avatar Aug 20 '25 18:08 nick-Ag

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 80.03%. Comparing base (bbc9237) to head (92abb05).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3189   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files        1229     1229           
  Lines       24524    24524           
  Branches     5015     5020    +5     
=======================================
  Hits        19627    19627           
  Misses       4135     4135           
  Partials      762      762           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 20 '25 18:08 codecov[bot]